tfks/fjx

Fork 0

Include PR in agent-dev's ledger #22

New issue

Closed

opened 2026-05-23 01:57:18 +00:00 by erik · 3 comments

erik commented

2026-05-23 01:57:18 +00:00

Owner

So we don't have to keep scanning for the PR link, have fjx make sure that "Refs: #PR" is included in the fjx-managed metadata for agent-dev's ledger.

erik added the

labels

2026-05-23 01:57:18 +00:00

agent-pm removed the

agent

new

label

2026-05-25 18:57:43 +00:00

agent-dev was assigned by agent-pm

2026-05-25 18:57:44 +00:00

agent-pm commented

2026-05-25 18:57:45 +00:00

Member

Brief — Developer

Phase: simple. Run fjx dev prompt simple for the cycle protocol.

# Brief — Developer **Phase:** simple. Run `fjx dev prompt simple` for the cycle protocol.

agent-pm commented

2026-05-25 18:57:46 +00:00

Member

Ledger for: agent-pm

Status: closed @ 2026-05-25T22:08:37.720Z
Briefs:

dev
qa: absent
build: absent

Activity

i22/closed : applied

(PM manages this ledger; agent section unused)

## Ledger for: agent-pm Status: closed @ 2026-05-25T22:08:37.720Z Briefs: - [dev](#issuecomment-1950) - qa: absent - build: absent ### Activity 1. i22/closed : applied --- _(PM manages this ledger; agent section unused)_

agent-dev added the

agent

working

label

2026-05-25 21:59:50 +00:00

agent-dev commented

2026-05-25 21:59:53 +00:00

Member

Ledger for: agent-dev

Status: review @ 2026-05-25T22:04:26.622Z

Tasks

Add Refs: #<PR> to fjx-managed dev ledger header — commit on chore/dev-ledger-refs-pr, PR #25.
Factor renderFjxManagedHeader out of makeLedgerCmd for testability; renderInitialLedger composes from it. No behavior change for non-dev roles.
Unit tests (src/ledger.test.ts) covering dev+PR, dev-no-PR, non-dev, and bootstrap paths.
just validate green (103 tests pass; lint/types/format/coverage/audit/secrets/sast).

Notes

PR lookup uses cache.pr_branch when present (no extra API call), otherwise falls back to findLinkedPr(client, itemId). Bootstrap ledger (fjx dev next) is unchanged because there is no PR yet at claim time — the Refs: line appears on the first fjx dev ledger --status … call made after the PR has been opened (with a newly-installed fjx from this branch).

## Ledger for: agent-dev Status: review @ 2026-05-25T22:04:26.622Z --- ### Tasks - [x] Add `Refs: #<PR>` to fjx-managed dev ledger header — commit on `chore/dev-ledger-refs-pr`, PR #25. - [x] Factor `renderFjxManagedHeader` out of `makeLedgerCmd` for testability; `renderInitialLedger` composes from it. No behavior change for non-dev roles. - [x] Unit tests (`src/ledger.test.ts`) covering dev+PR, dev-no-PR, non-dev, and bootstrap paths. - [x] `just validate` green (103 tests pass; lint/types/format/coverage/audit/secrets/sast). ### Notes PR lookup uses `cache.pr_branch` when present (no extra API call), otherwise falls back to `findLinkedPr(client, itemId)`. Bootstrap ledger (`fjx dev next`) is unchanged because there is no PR yet at claim time — the `Refs:` line appears on the first `fjx dev ledger --status …` call made after the PR has been opened (with a newly-installed `fjx` from this branch).

erik referenced this issue from a commit

2026-05-25 22:03:33 +00:00

chore(ledger): include Refs: #<PR> in agent-dev's fjx-managed header

agent-dev referenced this issue

2026-05-25 22:03:54 +00:00

chore: include Refs: #<PR> in agent-dev's ledger header #25

agent-dev removed their assignment

2026-05-25 22:04:33 +00:00

agent-pm was assigned by agent-dev

2026-05-25 22:04:33 +00:00

agent-pm closed this issue

2026-05-25 22:08:50 +00:00