tfks/dropbear

Fork 0

Add microsecond manifest timestamps #16

Merged

erik merged 6 commits from bug/microsecond-timestamps into main

2026-06-25 04:23:40 +00:00

agent-dev commented

2026-06-24 23:11:13 +00:00

Member

Refs: #9

Summary

Encode manifest and tombstone created_at values as fixed-width UTC microsecond timestamps.
Preserve walker mtimes to microsecond precision and persist them as RFC3339Nano strings.
Replace manifest timestamp regex validation with RFC3339Nano parsing plus a literal Z suffix check.
Update schemas, fixtures, tests, and wiki notes for the new timestamp precision.

Validation

just check
GOTOOLCHAIN=go1.26.4+auto just validate

Note: plain just validate failed on the host go1.26.3 standard-library vulnerabilities reported by govulncheck; rerunning with the fixed go1.26.4 toolchain passed.

Refs: #9 --- ## Summary - Encode manifest and tombstone `created_at` values as fixed-width UTC microsecond timestamps. - Preserve walker mtimes to microsecond precision and persist them as RFC3339Nano strings. - Replace manifest timestamp regex validation with RFC3339Nano parsing plus a literal `Z` suffix check. - Update schemas, fixtures, tests, and wiki notes for the new timestamp precision. ## Validation - `just check` - `GOTOOLCHAIN=go1.26.4+auto just validate` Note: plain `just validate` failed on the host `go1.26.3` standard-library vulnerabilities reported by `govulncheck`; rerunning with the fixed `go1.26.4` toolchain passed.

agent-dev added 1 commit

2026-06-24 23:11:13 +00:00

Add microsecond manifest timestamps

Validate / validate (pull_request) Successful in 1m47s

Details

effb8fefb4

agent-dev referenced this pull request

2026-06-24 23:11:30 +00:00

Add microsecond precision to created_at and entry mtimes #9

erik was assigned by agent-dev

2026-06-24 23:11:39 +00:00

agent-pm referenced this pull request

2026-06-24 23:50:54 +00:00

Add microsecond precision to created_at and entry mtimes #9

agent-qa referenced this pull request

2026-06-24 23:52:50 +00:00

Add microsecond precision to created_at and entry mtimes #9

agent-dev added 2 commits

2026-06-25 01:13:54 +00:00

Reject non-canonical entry mtimes e9aa56c6f1

Use canonical mtimes in manifest fixtures

Validate / validate (pull_request) Failing after 32s

Details

668c7d8d2f

agent-dev added 1 commit

2026-06-25 01:51:30 +00:00

Reject non-canonical typed manifest timestamps

Validate / validate (pull_request) Failing after 33s

Details

53aadb4794

erik added 2 commits

2026-06-25 04:22:13 +00:00

Format manifest entry mtimes with canonical fixed-width microseconds c416f66ae7

Entry mtimes were produced with time.RFC3339Nano, which trims trailing zeros (and drops the fraction entirely on a whole-second boundary), while the validator added in e9aa56c requires the fixed-width manifestTimeLayout with six fractional digits. The two disagree whenever a file's microsecond fraction has trailing zeros, so a peer rejects the manifest at decode and never applies the entry.

This surfaced as TestIntegrationTombstonePropagation passing locally (APFS nanosecond mtimes almost always fill six digits) but failing on CI, whose temp filesystem coarsens mtimes to whole seconds — fraction zero, RFC3339Nano emits "…:00Z", validator wants "…:00.000000Z", reject every time.

Add manifest.CanonicalTime as the single canonical formatter and use it on both producers (fswalk run/classify) so producer and validator share one source of truth. Regression test writes a file with a whole-second mtime and drives the full encode→DecodeManifest path a peer takes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Pin lint toolchain to the module go directive

Validate / validate (pull_request) Successful in 48s

Details

66ceae105a

golangci-lint embeds a typechecker built against a specific Go release, and GOTOOLCHAIN=auto lets a newer locally-installed Go drift ahead so the linter panics on stdlib it can't parse (seen locally with Go 1.26 against a 1.25-built golangci-lint). Pin GOTOOLCHAIN for the lint recipe to the version in go.mod's go directive so local matches CI regardless of installed Go; reading it from go.mod means a future go bump moves it automatically. Bump golangci-lint in lockstep when bumping Go.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

erik merged commit ae57cb0872 into main

2026-06-25 04:23:40 +00:00

erik deleted branch bug/microsecond-timestamps

2026-06-25 04:23:40 +00:00

erik referenced this pull request from a commit

2026-06-25 04:23:40 +00:00

Merge pull request 'Add microsecond manifest timestamps' (#16) from bug/microsecond-timestamps into main